Fix URL building logic #1320
Merged
Fix URL building logic #1320
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rahulpoddar-fyndna and @vikram-mahadevkar this is the fix for #1314. We hope to release it as soon as possible. |
cicoyle
reviewed
Apr 22, 2025
sdk-tests/src/test/java/io/dapr/it/methodinvoke/http/GH_1314_IT.java
Outdated
Show resolved
Hide resolved
artur-ciocanu
force-pushed
the
gh-1314
branch
2 times, most recently
from
6de971a to
bb030d1
Compare
siri-varma
reviewed
Apr 23, 2025
siri-varma
reviewed
Apr 23, 2025
sdk-tests/src/test/java/io/dapr/it/methodinvoke/http/GH_1314_IT.java
Outdated
Show resolved
Hide resolved
added 3 commits
April 23, 2025 10:14
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
added 6 commits
April 23, 2025 13:21
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
added 3 commits
April 25, 2025 21:07
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
|
@cicoyle @salaboy and @mcruzdev I have figured what was the problem with my setup. Here is the breakdown:
After I have went through all this hurdles, I was able to confirm that my fix works and there are no more double encodings. @cicoyle and @salaboy could you please review and approve. Thank you! CC: @rdosifyndna |
cicoyle
approved these changes
Apr 29, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
============================================
+ Coverage 76.91% 77.11% +0.19%
- Complexity 1592 1729 +137
============================================
Files 145 200 +55
Lines 4843 5291 +448
Branches 562 579 +17
============================================
+ Hits 3725 4080 +355
- Misses 821 899 +78
- Partials 297 312 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cicoyle
pushed a commit
to cicoyle/java-sdk
that referenced
this pull request
Apr 29, 2025
* Fix URL building logic Signed-off-by: Artur Ciocanu <[email protected]> * Add test for query params Signed-off-by: Artur Ciocanu <[email protected]> * Fix the assertion in the test Signed-off-by: Artur Ciocanu <[email protected]> * Adjust the tests Signed-off-by: Artur Ciocanu <[email protected]> * Remove uneeded changes from IT test Signed-off-by: Artur Ciocanu <[email protected]> * Revert some unintended changes Signed-off-by: Artur Ciocanu <[email protected]> * Simplify the testing a little bit Signed-off-by: Artur Ciocanu <[email protected]> * Adjust the test to use ServerRequest Signed-off-by: Artur Ciocanu <[email protected]> * Test removing things from method invoke controller Signed-off-by: Artur Ciocanu <[email protected]> * Add query param encoding test Signed-off-by: Artur Ciocanu <[email protected]> * Revert some unintended changes Signed-off-by: Artur Ciocanu <[email protected]> * Some tiny styles Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
cicoyle
pushed a commit
to cicoyle/java-sdk
that referenced
this pull request
Apr 29, 2025
* Fix URL building logic Signed-off-by: Artur Ciocanu <[email protected]> * Add test for query params Signed-off-by: Artur Ciocanu <[email protected]> * Fix the assertion in the test Signed-off-by: Artur Ciocanu <[email protected]> * Adjust the tests Signed-off-by: Artur Ciocanu <[email protected]> * Remove uneeded changes from IT test Signed-off-by: Artur Ciocanu <[email protected]> * Revert some unintended changes Signed-off-by: Artur Ciocanu <[email protected]> * Simplify the testing a little bit Signed-off-by: Artur Ciocanu <[email protected]> * Adjust the test to use ServerRequest Signed-off-by: Artur Ciocanu <[email protected]> * Test removing things from method invoke controller Signed-off-by: Artur Ciocanu <[email protected]> * Add query param encoding test Signed-off-by: Artur Ciocanu <[email protected]> * Revert some unintended changes Signed-off-by: Artur Ciocanu <[email protected]> * Some tiny styles Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
added a commit
that referenced
this pull request
Apr 29, 2025
* Fix URL building logic * Add test for query params * Fix the assertion in the test * Adjust the tests * Remove uneeded changes from IT test * Revert some unintended changes * Simplify the testing a little bit * Adjust the test to use ServerRequest * Test removing things from method invoke controller * Add query param encoding test * Revert some unintended changes * Some tiny styles --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a tiny PR that fixes the URL building logic in the DaprHttp functionality. This is trying to fix an issue where we tried to replace the OkHttp URL builder with something that uses JDK URI.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1314
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: